[SYCL] Fix DeclareSYCLBuiltins for round-trip setting. #3491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream LLVMadded a round-trip functionality to the command line args so that we can generate a full set of command line arguments from our existing state. At the moment, this is 'assert' build only, but it seems the intent is to make this perminent for future functionality. We will have to analyze the full set of our command line args to make sure we do this right (that is, that it gets set right the 2nd time), but this one fixes the DeclareSYCLBuiltins to unblock the pulldown's build.
erichkeane
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream LLVMadded a round-trip functionality to the command line args so
that we can generate a full set of command line arguments from our
existing state. At the moment, this is 'assert' build only, but it
seems the intent is to make this perminent for future functionality.
We will have to analyze the full set of our command line args to make
sure we do this right (that is, that it gets set right the 2nd time),
but this one fixes the DeclareSYCLBuiltins to unblock the pulldown's
build.