[SYCL][FPGA] Changing "slave" to "agent"

[aarogon]

All the instances of "slave" have been changed to "agent" following
inclusivity guidelines. Lit tests pass with the changes.

IntelFPGALocalStaticSlaveMemVar has been deprecated.

[AaronBallman]

Oof, we changed seven subject lists to emit different diagnostic text and only needed to change one test case. That suggests we're missing some test coverage for subject appertainment for these (that's not your problem to worry about in this review, just an observation).

[AaronBallman]

Btw, thank you for working on this, it's a great cleanup!

[aarogon]

I had intentionally left IntelFPGALocalStaticSlaveMemVar for deprecation reasons, because someone may be using it downstream.

[AaronBallman]

I had intentionally left IntelFPGALocalStaticSlaveMemVar for deprecation reasons, because someone may be using it downstream.

I don't think it's worth it. Downstream users are welcome to add it back in their downstream if they still need it.

[AaronBallman]

LGTM!

[keryell]

Interesting!
The code I am working on is full of AXI master and AXI slave... Any suggestion?
At the same time this is part of an existing specification :-( https://developer.arm.com/documentation/ihi0051/a/Introduction/About-the-AXI4-Stream-protocol

[AaronBallman]

Interesting!
The code I am working on is full of AXI master and AXI slave... Any suggestion?
At the same time this is part of an existing specification :-( https://developer.arm.com/documentation/ihi0051/a/Introduction/About-the-AXI4-Stream-protocol

If the existing specification exposes identifiers with those names, there's not much we can do aside from file an issue with the spec authors about their naming choices. However, for identifiers under our control, I'd recommend picking synonyms that describe the functionality. Some better names could be: controller/follower, source/sink, primary/secondary, etc.

(As an aside, this is also a good chance to correct any uses of whitelist/blacklist into better terms like allowlist/denylist, or sometimes better yet, AllowedWhatevers/RejectedWhatevers.)