Skip to content

[SYCL] Support extra environment variables in LIT #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

vladimirlaz
Copy link
Contributor

Add ability to set extra environment variables in CMake (LIT_EXTRA_ENVIRONMENT)
or LIT (extra_environment) parameters. The value should contain comma separated
VARIABLE=VALUE pairs.

Add ability to set extra environment variables in CMake (LIT_EXTRA_ENVIRONMENT)
or LIT (extra_environment) parameters. The value should contain comma separated
VARIABLE=VALUE pairs.
@vladimirlaz vladimirlaz requested a review from a team as a code owner April 22, 2021 11:10
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just let's document this somewhere how to use it.

@vladimirlaz
Copy link
Contributor Author

LGTM. Just let's document this somewhere how to use it.

The LIT infra for sycl/test is not documented. Will do that in separate PR.

@vladimirlaz vladimirlaz deleted the lit_extra_env branch April 23, 2021 06:26
@vladimirlaz vladimirlaz restored the lit_extra_env branch April 23, 2021 06:26
@vladimirlaz vladimirlaz reopened this Apr 23, 2021
@smaslov-intel
Copy link
Contributor

Will do that in separate PR.

OK

@bader bader merged commit cef2dd6 into intel:sycl Apr 24, 2021
@vladimirlaz vladimirlaz deleted the lit_extra_env branch April 26, 2021 05:40
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 27, 2021
* upstream/sycl:
  [NFC][SYCL] Avoid -Wreorder warning about order of initialization (intel#3620)
  [SYCL][DOC] Initial Draft of Extension for querying free device memory on Level Zero (intel#3468)
  [SYCL][PI][L0] Submit open command batch on event status query (intel#3612)
  [NFC] Fix the comment (intel#3613)
  Rename misleading attribute flag (intel#3610)
  [SYCL] Generate an opt report of kernel arguments.  (intel#3492)
  [SYCL] Support extra environment variables in LIT (intel#3598)
  [SYCL][Matrix] Make joint_matrix_mad return A*B+C's result instead of C=A*B+C (intel#3586)
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 28, 2021
* upstream/sycl:
  [SYCL][Doc] Add group sorting algorithms extension specification (intel#3514)
  [Buildbot] Update Windows GPU driver to 27.20.100.9466 (intel#3594)
  [SYCL][NFC] Update tests for FPGA attributes (intel#3632)
  [CODEOWNERS] Add @kbobrovs back to few projects (intel#3638)
  [NFC] Update codeowners (intel#3619)
  [SYCL] Support 3-, 16-elements vectors in SG load/store (intel#3617)
  [SYCL-PTX] Fix libclc dependencies (intel#3624)
  [SYCL] Add sycl::span for SYCL2020 support (intel#3569)
  [NFC][SYCL] Avoid -Wreorder warning about order of initialization (intel#3620)
  [SYCL][DOC] Initial Draft of Extension for querying free device memory on Level Zero (intel#3468)
  [SYCL][PI][L0] Submit open command batch on event status query (intel#3612)
  [NFC] Fix the comment (intel#3613)
  Rename misleading attribute flag (intel#3610)
  [SYCL] Generate an opt report of kernel arguments.  (intel#3492)
  [SYCL] Support extra environment variables in LIT (intel#3598)
  [SYCL][Matrix] Make joint_matrix_mad return A*B+C's result instead of C=A*B+C (intel#3586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants