[SYCL] Rename helper functions to avoid collision #3665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helper functions have the same names but different signatures to the ones to be mapped to SPIR-V operations. That makes some backends generate external calls for them which causes undefined reference on JIT compilation. The problem is seen only when compiling with -O0 or -O1 optimization options because when -O3 or -O2 are used helper functions are inlined and definitions are removed from final code eliminating the issue.
|
@rbegam, @romanovvlad, could you please have a look? |
romanovvlad
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper functions have the same names but different signatures to the
ones to be mapped to SPIR-V operations. That makes some backends
generate external calls for them which causes undefined reference
on JIT compilation. The problem is seen only when compiling with
-O0 or -O1 optimization options because when -O3 or -O2 are used
helper functions are inlined and definitions are removed from final
code eliminating the issue.