[SYCL][CMake] Move opencl-aot to opencl #3670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvchupin
requested review from
AlexeySachkov,
bader,
dm-vodopyanov,
romanovvlad and
a team
as code owners
|
Thanks, please update https://github.com/intel/llvm/blob/sycl/.github/CODEOWNERS |
Good catch! Done. |
* Update opencl-aot target to reuse opencl deps * Add opencl-aot to standard SYCL bundle instead of separate deploy * Update configure.py accordingly * Minor fix in cmake print message * Update CODEOWNERS to new paths Signed-off-by: Pavel V Chupin <[email protected]>
romanovvlad
approved these changes
May 6, 2021
|
I'm going to merge this now, few people are on vacations. I'll be happy to address remaining concerns separately. Please feel free to do post-commit review here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavel V Chupin [email protected]