[SYCL] small fix to alignment assertion #3671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
|
ping to reviewers. |
romanovvlad
approved these changes
May 4, 2021
|
review ping to codeowner: @smaslov-intel |
smaslov-intel
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several reasons
sycl::aligned_alloc_hostmight fail, for example if there is not enough memory. The present assertion seems to want to ensure that if the alignment is used that the memory is, ultimately, properly aligned. But it is too open and could instead assert if an alignment was specified and any failure occurred (even one not associated with alignment). This fix tightens that.Signed-off-by: Chris Perkins [email protected]