Skip to content

[SYCL] Cache sub-devices early such they can be seen by interop API #3690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2021

Conversation

smaslov-intel
Copy link
Contributor

Signed-off-by: Sergey V Maslov [email protected]

Signed-off-by: Sergey V Maslov <[email protected]>
bso-intel
bso-intel previously approved these changes May 5, 2021
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Nit: it would be great if you add some comments about why we always return max number of sub-devices regardless of the user's request.

@smaslov-intel
Copy link
Contributor Author

@bso-intel : I've additionally removed the lock from getDeviceFromNativeHandle. please review

bso-intel
bso-intel previously approved these changes May 5, 2021
Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Contributor

@bso-intel bso-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@againull againull merged commit 253d7fa into intel:sycl May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants