[SYCL][ESIMD] Move ESIMD APIs to sycl::ext::intel::experimental::esimd. #3695
Conversation
This makes the ESIMD extension namespace conforming to the SYCL2020 spec. Necessary file renames will be done as a separate commit. Signed-off-by: kbobrovs <[email protected]>
Signed-off-by: kbobrovs <[email protected]>
Signed-off-by: kbobrovs <[email protected]>
kbobrovs
force-pushed
the
change_esimd_namespace
branch
from
3b1ff3a to
5218483
Compare
|
Fixed test failures, rebased. |
|
@romanovvlad - please review few lines of changes in sycl/include/CL/sycl |
|
Jenkins failures are all SYCL/ESIMD tests from llvm-test-suite. This is fixed by intel/llvm-test-suite#270 |
|
@DenisBakhvalov, ping |
| @@ -18,7 +18,8 @@ | |||
| #include <assert.h> | |||
| #include <cstdint> | |||
|
|
|||
| #define __SIGD sycl::INTEL::gpu::detail | |||
| #define __SEIEED sycl::ext::intel::experimental::esimd::detail | |||
There was a problem hiding this comment.
For a future change, I'd like to see these macro names not be first letter of each of the namespaces. I'd like to have you choose a name like __ESIMD_NS that was at least a bit meaningful. But more importantly when ESIMD would move out of experimental, or otherwise change, I don't think you should have to change every single place these macros are used to designate the namespace. The changes to these added to a huge number of extra changes in this PR.
There was a problem hiding this comment.
Good point. Maybe it is better to do this change in this PR and retest to avoid disturbance in future. @pvchupin - what do you think?
There was a problem hiding this comment.
@kbsmith-intel, how about:
__ESIMD_NS, __ESIMD_DETAIL_NS, __ESIMD_EMU_NS, __ESIMD_EMU_DETAIL_NS
?
There was a problem hiding this comment.
Those names look good to me.
There was a problem hiding this comment.
These are internal macro, right? I'd prefer it to go as a follow up change. Since we already committed tests we should commit the change asap.
There was a problem hiding this comment.
Yes, those are internal. OK, I will make this as a follow-up PR
There was a problem hiding this comment.
I think followup would be fine also, and agree with Pavel that since tests have changed, getting source changes in ASAP is desired.
This makes the ESIMD extension namespace conforming to the SYCL2020 spec.
Necessary file renames will be done as a separate commit.
Changes to the llvm-test-suite are underway
Signed-off-by: kbobrovs [email protected]