Skip to content

[SYCL] Changed noinit to no_init according to the final published SYCL 2020 spec. #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 14, 2021
Merged

[SYCL] Changed noinit to no_init according to the final published SYCL 2020 spec. #3718

merged 9 commits into from
May 14, 2021

Conversation

pkeir
Copy link
Contributor

@pkeir pkeir commented May 8, 2021

This resolves #3659.

@pkeir pkeir requested review from a team as code owners May 8, 2021 12:06
@pkeir pkeir requested a review from smaslov-intel May 8, 2021 12:06
@gmlueck
Copy link
Contributor

gmlueck commented May 10, 2021

How long has the old spelling (noinit) been implemented? Is there an existing source base using the old spelling that we need to retain backward compatibility with? I wonder if we should keep the old spelling, but make it deprecated.

@pkeir
Copy link
Contributor Author

pkeir commented May 10, 2021

The noinit spelling was used only in the draft specification document for SYCL 2020. The oneAPI-samples use the old spelling, and I plan to submit a PR there as soon as this PR is resolved.

@smaslov-intel
Copy link
Contributor

The noinit spelling was used only in the draft specification document for SYCL 2020. The oneAPI-samples use the old spelling, and I plan to submit a PR there as soon as this PR is resolved.

I think we should go through the deprecation process here.

bader
bader reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple of minor comments.

@pkeir
Copy link
Contributor Author

pkeir commented May 11, 2021

I've added deprecated support for the old spelling. Both property::noinit and property::no_init inherit from detail::DataLessProperty<detail::NoInit>.

@gmlueck
Copy link
Contributor

gmlueck commented May 11, 2021

I've added deprecated support for the old spelling. Both property::noinit and property::no_init inherit from detail::DataLessProperty<detail::NoInit>.

Thanks!

bader
bader previously approved these changes May 12, 2021
View reviewed changes
@bader
Copy link
Contributor

bader commented May 12, 2021

LGTM. Thanks for working on this!

bader
bader reviewed May 13, 2021
View reviewed changes
@pkeir
Copy link
Contributor Author

pkeir commented May 14, 2021

Did something fail in the Jenkins/Precommit task? If I click the "Details" link, I receive the message: "This site can’t be reached".

@bader
Copy link
Contributor

bader commented May 14, 2021

Did something fail in the Jenkins/Precommit task? If I click the "Details" link, I receive the message: "This site can’t be reached".

Yes, but these failures doesn't seem to be related to your changes. I have the same failures in my PR.

@bader bader requested review from gmlueck and alexbatashev May 14, 2021 09:30
@bader bader mentioned this pull request May 14, 2021
Closed
@bader bader merged commit ad46b64 into intel:sycl May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@alexbatashev alexbatashev alexbatashev approved these changes

@gmlueck gmlueck gmlueck approved these changes

@smaslov-intel smaslov-intel Awaiting requested review from smaslov-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SYCL2020] sycl::noinit -> sycl::no_init
5 participants
@pkeir @gmlueck @smaslov-intel @bader @alexbatashev