[SYCL] Avoid HasDefaultValues to be set as IsSet field of SpecConstDescT #3813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove backward compatibility according to discussion: https://github.com/intel/llvm/pull/3667/files#r631154823i This patch is expected to be merged together or before intel#3666
vmaksimo
added a commit
to vmaksimo/llvm
that referenced
this pull request
May 25, 2021
Moving to intel#3813
dm-vodopyanov
approved these changes
May 25, 2021
| @@ -205,7 +205,7 @@ static sycl::unittest::PiImage generateDefaultImage() { | |||
| sycl::unittest::PiImage Img = generateDefaultImage(); | |||
| sycl::unittest::PiImageArray ImgArray{Img}; | |||
|
|
|||
| TEST(DefaultValues, DefaultValuesAreSet) { | |||
| TEST(DefaultValues, DISABLED_DefaultValuesAreSet) { | |||
There was a problem hiding this comment.
Shall we submit some issue to re-enable those tests? Or someone is already working on a fix?
There was a problem hiding this comment.
@alexbatashev or myself will fix it. Internal ticket was submitted.
alexbatashev
approved these changes
May 26, 2021
AlexeySachkov
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove backward compatibility according to discussion:
#3667 (comment)
This patch is expected to be merged together or before
#3666