[SYCL] Enable ITT notification support in SYCL Runtime #3832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anihilator2
approved these changes
May 27, 2021
Anihilator2
approved these changes
May 27, 2021
Anihilator2
approved these changes
May 27, 2021
|
I did not find anything wrong in this patch, but the changed places are not familiar to me. Thus it would be good if someone else (perhaps, @kbobrovs) also take a look at this PR. |
s-kanaev
reviewed
Jun 3, 2021
s-kanaev
approved these changes
Jun 4, 2021
| @@ -49,6 +49,17 @@ enum BuildState { BS_InProgress, BS_Done, BS_Failed }; | |||
|
|
|||
| static constexpr char UseSpvEnv[]("SYCL_USE_KERNEL_SPV"); | |||
|
|
|||
| /// This function enables ITT annotations in SPIR-V module by setting | |||
| /// a specialization constant if INTEL_LIBITTNOTIFY64 env variable is set. | |||
There was a problem hiding this comment.
You mean INTEL_ENABLE_OFFLOAD_ANNOTATIONS, right?
There was a problem hiding this comment.
That's right, I forgot to update the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.