Skip to content

[SYCL] Fix build options merge in program manager #3849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

vladimirlaz
Copy link
Contributor

@vladimirlaz vladimirlaz commented May 30, 2021

The program manager gets build options from several sources including
device code image, SYCL API and environment variables. Make sure that
options are space separated.
E2E tests for the change: intel/llvm-test-suite#302

The program manager gets build options from several sources including
device code image, SYCL API and environment variables. Make sure that
options are space separated.
@vladimirlaz vladimirlaz marked this pull request as ready for review May 31, 2021 05:13
@vladimirlaz vladimirlaz requested a review from a team as a code owner May 31, 2021 05:13
@vladimirlaz vladimirlaz requested a review from romanovvlad May 31, 2021 05:13
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladimirlaz vladimirlaz requested a review from romanovvlad May 31, 2021 10:22
@vladimirlaz vladimirlaz merged commit 6741147 into intel:sycl Jun 1, 2021
@vladimirlaz vladimirlaz deleted the fix_build_options_concat branch October 8, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants