[SYCL] Use macro SYCL_REDUCTION_DETERMINISTIC for stable reduction re… #3876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sults The macro SYCL_REDUCTION_DETERMINISTIC is not defined by default. This patch also has NFC portion which removes reduction only specific code from known_identity.hpp file. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Pennycook
reviewed
Jun 4, 2021
Comment on lines
+45
to
+47
| #ifdef SYCL_REDUCTION_DETERMINISTIC | ||
| bool_constant<false>; | ||
| #else |
There was a problem hiding this comment.
Is this sufficient to guarantee determinism? I don't think the work-group/sub-group reduction functions are guaranteed to be deterministic across all devices. Since there's only one implementation that's guaranteed to be deterministic (i.e. the manual tree reduction), why not guard all but that implementation behind ifndef SYCL_REDUCTION_DETERMINISTIC?
There was a problem hiding this comment.
Right. I disabled reduce() algorithm when the macro is defined: ead7383
…efined Signed-off-by: Vyacheslav N Klochkov <[email protected]>
…deterministic_macro
Pennycook
approved these changes
Jun 4, 2021
sergey-semenov
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sults
The macro SYCL_REDUCTION_DETERMINISTIC is not defined by default.
This patch also has NFC portion which removes reduction only specific
code from known_identity.hpp file.
Signed-off-by: Vyacheslav N Klochkov [email protected]