Skip to content

[Driver][SYCL] Improve handling of integration footers when preprocessing #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 8, 2021

Conversation

mdtoguchi
Copy link
Contributor

When generating and consuming preprocessed files with the integration
footer enabled, we need to properly setup the tools used during each
particular step.

Generation: preprocess host -> append footer -> preprocess again
Use: compile preprocessed file

When generating and consuming preprocessed files with the integration
footer enabled, we need to properly setup the tools used during each
particular step.

Generation:  preprocess host -> append footer -> preprocess again
Use: compile preprocessed file
@mdtoguchi mdtoguchi requested a review from AGindinson as a code owner June 4, 2021 00:28
@mdtoguchi mdtoguchi marked this pull request as draft June 4, 2021 01:28
@mdtoguchi mdtoguchi marked this pull request as ready for review June 4, 2021 22:17
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the earlier comments, LGTM other than a single typo.

@AGindinson AGindinson changed the title [Driver][SYCL] Improve handing of integration footers when preprocessing [Driver][SYCL] Improve handling of integration footers when preprocessing Jun 8, 2021
@bader bader merged commit ce7177d into intel:sycl Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants