[SYCL][FPGA] Apply [[intel::use_stall_enable_clusters]] attribute to any function #3900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ANY function [[intel::use_stall_enable_clusters]] is a function attribute, not a kernel one. It can be applied to any function or lambda. This patch removes the restriction that was added on PR: intel#2734 to allow propagating the attribute to kernel if it is applied to any function the kernel calls. Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
smanna12
changed the title
Signed-off-by: Soumi Manna <[email protected]>
smanna12
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
erichkeane
reviewed
Jun 8, 2021
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
erichkeane
reviewed
Jun 9, 2021
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Thanks Aaron. |
|
Thanks you everyone for the reviews and discussion. |
|
@vladimirlaz, could you please merge this PR? Thanks. |
AaronBallman
pushed a commit
that referenced
this pull request
Jul 6, 2021
This patch collects and applies the FPGA attribute intel::use_stall_enable_clusters to the callers/SYCL kernel if directly applied through functors/lambda function. The attribute has to be applicable to all functions, which can include the SYCL kernels and must not be propagated up to the caller/SYCL kernel when called from a function. This patch fixes FPGA emulator bug that was introduced on #3900.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[[intel::use_stall_enable_clusters]] is a function attribute, not a kernel one.
It can be applied to any function or lambda. This patch removes the
incorrect behavior that was added on PR: #2734 where
the metadata to be attached to the FunctionDecl/IR Function that the attribute is applied to.
Signed-off-by: Soumi Manna [email protected]