[SYCL][NFC] Make all of the Util::isNNNType functions auto-canonicalize #3916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only really care about picking up the record-decl that the type refers to, so we should just remove specifiers/qualifiers for all calls.
erichkeane
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
elizabethandrews
approved these changes
Jun 10, 2021
bader
changed the title
erichkeane
pushed a commit
to erichkeane/llvm
that referenced
this pull request
Jun 10, 2021
|
I tried in a few places and couldn't come up with a reproducer that counts on this, I suspect that something somewhere else must be canonicalizing in a way that I don't see. Even the patch that precipitated this doesn't have this problem as far as I can tell (I think I left it in during debugging?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only really care about picking up the record-decl that the type
refers to, so we should just remove specifiers/qualifiers for all calls.