[SYCL][NFC] Use relative paths for SYCL headers install #3940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dm-vodopyanov
changed the title
`${SYCL_INCLUDE_DEPLOY_DIR}` is defined as
`${CMAKE_INSTALL_PREFIX}/${SYCL_INCLUDE_DIR}`, this is unnecessary
because when using relative paths, CMake will automatically prefix
install destinations with `${CMAKE_INSTALL_PREFIX}`, so we can directly
use `${SYCL_INCLUDE_DIR}`.
It is also preferable to use relative paths, because it enables the
`DESTDIR` mechanism that can make it possible to change the install
prefix after the configuration, with for example things like `make
DESTDIR=/new/install/prefix install`, or when manually calling the CMake
install scripts.
This patch has no functional changes and should have no effect on
existing builds, aside from enabling `DESTDIR`.
npmiller
force-pushed
the
sycl-cmake-install-fix
branch
from
384e583 to
41748ee
Compare
dm-vodopyanov
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${SYCL_INCLUDE_DEPLOY_DIR}is defined as${CMAKE_INSTALL_PREFIX}/${SYCL_INCLUDE_DIR}, this is unnecessarybecause when using relative paths, CMake will automatically prefix
install destinations with
${CMAKE_INSTALL_PREFIX}, so we can directlyuse
${SYCL_INCLUDE_DIR}.It is also preferable to use relative paths, because it enables the
DESTDIRmechanism that can make it possible to change the installprefix after the configuration, with for example things like
make DESTDIR=/new/install/prefix install, or when manually calling the CMakeinstall scripts.
This patch has no functional changes and should have no effect on
existing builds, aside from enabling
DESTDIR.