[Driver][FPGA][SYCL] Add specific timing diagnostic for FPGA AOT #3965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases in which the generation of FPGA device code from 'aoc' is known to have timing issues. Add a specific diagnostic from the driver when this case is encountered. A special return code (42) is used to inform the driver of this situation. Additionally in this situation, we also want to allow for the compilation to continue so the user can use the generated binary knowing the timing issue as stated.
|
Only |
AGindinson
reviewed
Jun 28, 2021
AlexeySachkov
previously approved these changes
Jun 28, 2021
Use separate DenseMap for exit behaviors Update names and usage model to avoid double negatives
|
@AlexeySachkov, can you take another look? |
|
@bader, can this be merged without |
bader
reviewed
Jul 6, 2021
AGindinson
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases in which the generation of FPGA device code from 'aoc'
is known to have timing issues. Add a specific diagnostic from the
driver when this case is encountered. A special return code (42) is
used to inform the driver of this situation.
Additionally in this situation, we also want to allow for the compilation
to continue so the user can use the generated binary knowing the timing
issue as stated.