[SYCL] Rename usm_system_allocator to usm_system_allocations #4007
Conversation
This patch renames usm_system_allocator to usm_system_allocations to conform SYCL 2020 spec.
|
@rbegam, ping. |
…_system_allocations
|
@sergey-semenov, can you please review? |
|
The change LGTM overall, but I'm a little bit concerned about the existing code that may use the old non-conformant value which was introduced 5 months ago. @romanovvlad Do you think this is something we should worry about in cases like this? Does it make sense to deprecate then remove the incorrect value here? |
dm-vodopyanov
changed the title
Yes, I think we should keep old value and mark with a deprecation warning. There might be code using it already. |
…ocations' of https://github.com/dm-vodopyanov/llvm into private/dvodopya/usm_system_allocator_to_usm_system_allocations
…_system_allocations
|
@sergey-semenov, can you please review? |
dm-vodopyanov
deleted the
private/dvodopya/usm_system_allocator_to_usm_system_allocations
branch
As mentioned in the CTS pull request KhronosGroup/SYCL-CTS#870, two device info descriptors, namely `info::device::image_max_array_size` and `info::device::opencl_c_version`, have been deprecated and no longer exist in the SYCL 2020 specification. But they still exist in our implementation, so I'm setting up deprecation warnings for them. Also a related test case has been revised to remove the usage of `info::device::opencl_c_version`. Also `info::device::usm_system_allocator` has been replaced and marked as deprecated 2+ years ago in PR #4007 and #9217 respectively. So I'm cleaning up a few relevant code pieces in our code as well in this PR. --------- Signed-off-by: Hu, Peisen <[email protected]>
This patch renames usm_system_allocator to usm_system_allocations to
conform SYCL 2020 spec.