[SYCL] Implement more verbose error handling. #4013
Conversation
This ensures that no exception is silently ignored by sycl. This also includes API names and error codes in the error messages. Signed-off-by: rehana begam <[email protected]>
Signed-off-by: rehana begam <[email protected]>
I am not sure it is a good idea to show PI API names to the user since they aren't documented anywhere. |
sycl/source/detail/program_impl.cpp
Outdated
| @@ -362,7 +362,8 @@ void program_impl::create_cl_program_with_source(const std::string &Source) { | |||
| } | |||
|
|
|||
| if (Err != PI_SUCCESS) { | |||
| Plugin.reportPiError(Err, "create_cl_program_with_source()"); | |||
| std::string CallingFunction = "create_cl_program_with_source()"; | |||
| Plugin.reportPiError(Err, CallingFunction); | |||
There was a problem hiding this comment.
what's wrong with prev version?
There was a problem hiding this comment.
there were compile errors as std::string & requires a lvalue.
There was a problem hiding this comment.
Maybe use std::string_view?
There was a problem hiding this comment.
it is kind of ugly that you cannot pass C-string directly, either use string_view or just "const char*"
There was a problem hiding this comment.
agree. how about using std::string instead of std::string &? that will resolve the lvalue issue.
There was a problem hiding this comment.
This way there would be a copy made during the call. How about using "std::string &" but passing as string("bla-bla-bla")
There was a problem hiding this comment.
this didn't work either. i am using const char*
sycl/source/detail/program_impl.cpp
Outdated
| @@ -362,7 +362,8 @@ void program_impl::create_cl_program_with_source(const std::string &Source) { | |||
| } | |||
|
|
|||
| if (Err != PI_SUCCESS) { | |||
| Plugin.reportPiError(Err, "create_cl_program_with_source()"); | |||
| std::string CallingFunction = "create_cl_program_with_source()"; | |||
| Plugin.reportPiError(Err, CallingFunction); | |||
There was a problem hiding this comment.
it is kind of ugly that you cannot pass C-string directly, either use string_view or just "const char*"
This ensures that no exception is silently ignored by sycl. This
also includes API names and error codes in the error messages.
Signed-off-by: rehana begam [email protected]