[SYCL][PI][L0] Changes std:string to const char * for ZeCallCount #4018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes to use plain const char * for the ZeCallCount map rather than std:string. This saves std:string construction and destruction overhead when ZE_DEBUG=4 is being used. It also saves about 2% code size for the shared library due to this overhead being removed. This change should not result in any noticeable change in the plug-ins behavior.
smaslov-intel
approved these changes
Jun 29, 2021
Because I noticed that is was causing extra overhead, the same as other places, and it made sense to me to do this consistently. Plus it decreases the chances of later developers copying the inefficient code, and thinking that it is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes to use plain const char * for the ZeCallCount map
rather than std:string. This saves std:string construction
and destruction overhead when ZE_DEBUG=4 is being used. It also
saves about 2% code size for the shared library due to this
overhead being removed.
This change should not result in any noticeable change in the
plug-ins behavior.