[sycl-post-link] Support indirectly called assert #4027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per design doc (https://github.com/intel/llvm/blob/sycl/sycl/doc/Assert.md): If a callgraph for indirect callable function (marked with specific attribute) has a call to __devicelib_assert_fail, then all kernels in the module are conservatively marked as using asserts.
vmaksimo
requested review from
AlexeySachkov,
kbobrovs and
mlychkov
as code owners
| @@ -547,15 +555,36 @@ static string_vector saveDeviceImageProperty( | |||
|
|
|||
| { | |||
| Module *M = ResultModules[I].get(); | |||
| bool HasIndirectlyCalledAssert = false; | |||
| std::vector<llvm::Function *> Kernels; | |||
| for (auto &F : M->functions()) { | |||
| // TODO: handle SYCL_EXTERNAL functions for dynamic linkage. | |||
| // TODO: handle function pointers. | |||
There was a problem hiding this comment.
This TODO can be now removed
There was a problem hiding this comment.
Not sure that it's right to remove it - we haven't implemented this yet.
|
@mlychkov could you please review the change? thanks! |
mlychkov
previously approved these changes
Jul 7, 2021
mlychkov
reviewed
Jul 8, 2021
mlychkov
reviewed
Jul 8, 2021
mlychkov
reviewed
Jul 8, 2021
Co-authored-by: Mikhail Lychkov <[email protected]>
mlychkov
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per design doc (https://github.com/intel/llvm/blob/sycl/sycl/doc/Assert.md):
If a callgraph for indirect callable function (marked with specific attribute)
has a call to __devicelib_assert_fail, then all kernels in the module are
conservatively marked as using asserts.