Skip to content

[SYCL] Fix Windows Shutdown Failure #4040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

bso-intel
Copy link
Contributor

@bso-intel bso-intel commented Jul 2, 2021

The function DllMain() is missing important attribute, so shutdown was never called on Windows before.

Signed-off-by: Byoungro So [email protected]

The function DllMain() is missing important attribute, so shutdown was never called before.

Signed-off-by: Byoungro So <[email protected]>
@bso-intel bso-intel marked this pull request as ready for review July 2, 2021 17:14
@bso-intel bso-intel requested a review from a team as a code owner July 2, 2021 17:14
@bso-intel bso-intel requested a review from alexbatashev July 6, 2021 06:35
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
I am surprised this is not mentioned in the docs

@romanovvlad romanovvlad merged commit 1dea757 into intel:sycl Jul 6, 2021
@bso-intel bso-intel deleted the win-shutdown branch July 6, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants