[SYCL] Fix bool parameters in CUDA and ROCm plugins #4059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Device parameters are `pi_bool`, which is `uint32_t`, not `bool`. So using `bool` here is incorrect because it will only set one byte of the expected 4 bytes output. If the output is initialized to 0 this will work fine, but if it's not this results in undefined behaviour.
|
@smaslov-intel, @intel/llvm-reviewers-cuda, ping. |
smaslov-intel
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Device parameters are
pi_bool, which isuint32_t, notbool.So using
boolhere is incorrect because it will only set one byte ofthe expected 4 bytes output. If the output is initialized to 0 this
will work fine, but if it's not this results in undefined behaviour.