[SYCL][ROCm] Fix context destruction on AMD #4104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What this piece of code is doing is making the context being destroyed "current" by pushing it, so that it can be synchronized, and then popping it. However on AMD the synchronization is not supported, nor necessary, so these steps can be skipped. In addition this was causing issues because on AMD it uses a single context under the hood so `hipCtxt == current` is always true, which means that this piece of code was popping the context without pushing it first which would return an error code. Simply skipping this step on AMD should be fine.
smaslov-intel
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this piece of code is doing is making the context being destroyed
"current" by pushing it, so that it can be synchronized, and then
popping it.
However on AMD the synchronization is not supported, nor necessary, so
these steps can be skipped. In addition this was causing issues because
on AMD it uses a single context under the hood so
hipCtxt == currentis always true, which means that this piece of code was popping the
context without pushing it first which would return an error code.
Simply skipping this step on AMD should be fine.