[SYCL] Fix vec::convert method. #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was the old code for device completely broken? If yes, approved. Else, salvage where floor/ceil was working. |
bader
reviewed
Jul 29, 2019
|
@alexeyvoronov wrote privately: If this is the case, I don't have any more comments. Please address the comment by @bader where applicable. |
bader
reviewed
Aug 15, 2019
| sycl::int8{2, 3, 3, -2, -3, -3, 0, 0}); | ||
| test<float, int, 8, rounding_mode::automatic>( | ||
| sycl::float8{+2.3f, +2.5f, +2.7f, -2.3f, -2.5f, -2.7f, 0.f, 0.f}, | ||
| #ifdef ROUNDING_MODES_IMPLEMENTED |
There was a problem hiding this comment.
Please, remove this macro.
Rounding modes must be supported by convert method.
Fixed non-compiling code. Added support for rounding modes on the host device. Signed-off-by: Alexey Voronov <[email protected]>
alexeyvoronov-intel
force-pushed
the
private/avoronov/vec_convert_host_side
branch
from
6d41818 to
e78c51d
Compare
bader
approved these changes
Aug 15, 2019
alexeyvoronov-intel
deleted the
private/avoronov/vec_convert_host_side
branch
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Jan 18, 2021
CONFLICT (content): Merge conflict in llvm/lib/Support/Triple.cpp CONFLICT (content): Merge conflict in llvm/include/llvm/ADT/Triple.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed non-compiling code.
Added support for rounding modes on the host device.
Signed-off-by: Alexey Voronov [email protected]