[SYCL] Fast launch of kernels that have no dependencies #4188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Flegontov <[email protected]>
|
/summary:run |
againull
reviewed
Jul 30, 2021
|
sure, I've updated the description. |
romanovvlad
pushed a commit
that referenced
this pull request
Nov 10, 2021
The changes make even more performance optimization for calling kernels that have no dependencies, starting in the #4188. If a kernel doesn't change the execution command graph then the time spent on allocation and deallocation objects of the ExecCGCommand and CGExecKernel classes can be reduced by simply not creating them and directly calling kernel submission function(i.e enqueueImpKernel). Signed-off-by: Alexander Flegontov [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to reduce the time for the specific case when the kernel doesn't have any dependencies.
If the kernel doesn't use accessors, then the vector
MRequirementsis empty.If the kernel doesn't depend on other events, then the vector
MEventsis empty.In most cases this is the kernel that uses USM memory only, for such cases, the patch is intended.
Since the vectors
MRequirementsandMEventsare empty forExecCGCommand,ExecCGCommandof such kernel doesn't affect the command graph and is not added as a node.Since this command doesn't depend on the graph in any way, it can be safely executed independently, without going through the mechanism of placing it into the queue, which in this case is meaningless. Thus, the command can be executed instantly.
This significantly saves time that could be wasted in:
Here
printGraphAsDotis useless because the graph isn't changed and this is used only to support the old behavior, and this can be removed if desired.Signed-off-by: Alexander Flegontov [email protected]