[SYCL][L0][PI] Add support for link copy engines #4221
Conversation
Signed-off-by: Arvind Sudarsanam <[email protected]>
| // to which the command list (if any) will be submitted. | ||
| // If there is no command list, or if the command list is not a copy command | ||
| // list, the value is set to -1. | ||
| int CopyQueueIndex; |
There was a problem hiding this comment.
can't you use CopyQueueIndex == -1 check to replace the IsCopyCommandList member?
There was a problem hiding this comment.
Yes. I think we can.
| // Currently, a round robin strategy is used. | ||
| // It will return nullptr if no copy command queues are available for use. | ||
| ze_command_queue_handle_t | ||
| getZeCopyCommandQueue(int &CopyQueueIndex, |
There was a problem hiding this comment.
I suggest to make first argument a pointer for consistency
There was a problem hiding this comment.
Addressed this in the next patch. Thanks
|
Can we start writing component tests for L0 plugin? It could be applications that call PI API of plugins and checks that calls to L0 API are correct(similar to how we check that SYCL API is lowered correctly to PI API). |
|
Hi @romanovvlad Thanks |
Ok. |
Signed-off-by: Arvind Sudarsanam [email protected]