Skip to content

[SYCL] Return static to has_property and get_property methods #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2021
Merged

[SYCL] Return static to has_property and get_property methods #4240

merged 4 commits into from
Aug 12, 2021

Conversation

denis-kabanov
Copy link
Contributor

Fix regression related to missing static identifier for has_property and get_property methods. Without a static identifier, errors occur in the previously valid code.

Fix regression related to missing static identifier for has_property and get_property methods. Without a static identifier, errors occur in the previously valid code.
@denis-kabanov denis-kabanov requested a review from a team as a code owner August 3, 2021 15:58
alexbatashev
alexbatashev previously approved these changes Aug 3, 2021
@romanovvlad
Copy link
Contributor

@tfzhu
The LIT_With_Cuda is in pending state on this page, but opening Details page I see that the job has finished 20h ago.
This seems wrong and blocks the PR.
Could you please take a look?

@tfzhu
Copy link
Contributor

tfzhu commented Aug 11, 2021

@tfzhu
The LIT_With_Cuda is in pending state on this page, but opening Details page I see that the job has finished 20h ago.
This seems wrong and blocks the PR.
Could you please take a look?

Rerun the build. Network issue when buildbot tried to update status.

@bader bader merged commit f387c5a into intel:sycl Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants