Skip to content

[Driver][SYCL] Update header inclusion for source + footer #4241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

mdtoguchi
Copy link
Contributor

Instead of using -internal-isystem for the source location header inclusion,
use -I as a user header, but be sure it is placed after user defined -I
locations.

Instead of using -internal-isystem for the source location header inclusion,
use -I as a user header, but be sure it is placed after user defined -I
locations.
@mdtoguchi mdtoguchi requested a review from AGindinson as a code owner August 3, 2021 16:59
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to the change, just curious as to the issues that the previous solution had run into.

@mdtoguchi
Copy link
Contributor Author

No objections to the change, just curious as to the issues that the previous solution had run into.

Ran into a compilation failure in SYCL_CI with a test where headers weren't being resolved as expected.

@AGindinson
Copy link
Contributor

/summary:run

@AGindinson
Copy link
Contributor

@bader, I believe this PR is safe to merge, since the post-commit failures were Linux-specific, and the current Summary shows no such regressions. Thanks.

@bader
Copy link
Contributor

bader commented Aug 5, 2021

@bader, I believe this PR is safe to merge, since the post-commit failures were Linux-specific, and the current Summary shows no such regressions. Thanks.

@AGindinson, why do you think this patch can't regress tests on Windows? Was this version of the patch tested on Windows already?

@AGindinson
Copy link
Contributor

@AGindinson, why do you think this patch can't regress tests on Windows? Was this version of the patch tested on Windows already?

Fair point.

@bader bader merged commit e5e6a7f into intel:sycl Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants