Skip to content

[SYCL] Widen (u)int8/16 to (u)int32 in group operations #4242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021
Merged

[SYCL] Widen (u)int8/16 to (u)int32 in group operations #4242

merged 1 commit into from
Aug 5, 2021

Conversation

dnmokhov
Copy link
Contributor

@dnmokhov dnmokhov commented Aug 3, 2021

CPU device does not yet support the (u)int8/16 versions.

CPU device does not yet support the (u)int8/16 versions.
@dnmokhov
Copy link
Contributor Author

dnmokhov commented Aug 4, 2021

/summary:run

@dnmokhov dnmokhov marked this pull request as ready for review August 4, 2021 07:24
@dnmokhov dnmokhov requested a review from a team as a code owner August 4, 2021 07:24
@dnmokhov dnmokhov requested review from againull and v-klochkov August 4, 2021 07:24
Copy link
Contributor

@v-klochkov v-klochkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@Pennycook would you please take a quick look at this patch.

@dnmokhov dnmokhov requested a review from Pennycook August 5, 2021 05:27
Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to check what this means (if anything) for future releases, since there are some tests here checking that everything lowers to i32 in the SPIR-V. When the CPU device supports the 8-bit and 16-bit group operations natively, how difficult is it going to be to revert this change? Will it trigger any API/ABI breakage concerns?

@dnmokhov
Copy link
Contributor Author

dnmokhov commented Aug 5, 2021

I just want to check what this means (if anything) for future releases, since there are some tests here checking that everything lowers to i32 in the SPIR-V. When the CPU device supports the 8-bit and 16-bit group operations natively, how difficult is it going to be to revert this change? Will it trigger any API/ABI breakage concerns?

My understanding is that reverting this change will make newly compiled kernels use the i8/i16 __spirv_GroupXXX API versions. The i32 ones will still be there, so

  • kernels compiled with this change will work with old and new CPU drivers;
  • kernels compiled after reverting this change will require new CPU drivers.

@Pennycook
Copy link
Contributor

My understanding is that reverting this change will make newly compiled kernels use the i8/i16 __spirv_GroupXXX API versions. The i32 ones will still be there, so

  • kernels compiled with this change will work with old and new CPU drivers;
  • kernels compiled after reverting this change will require new CPU drivers.

Ok, that makes sense. Thanks for the explanation.

@v-klochkov v-klochkov merged commit 6a055ec into intel:sycl Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants