[SYCL] Omit extensions (.a .o .out .lib .obj .exe) in output project … #4250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdtoguchi
reviewed
Aug 4, 2021
qichaogu
force-pushed
the
output-project-dir-name
branch
2 times, most recently
from
3fc99ec to
2fcfb10
Compare
mdtoguchi
previously approved these changes
Aug 4, 2021
qichaogu
force-pushed
the
output-project-dir-name
branch
2 times, most recently
from
1b9f036 to
42efd79
Compare
…directory name For "-o file.xxx" where the option value has an extension, if the extension is one of .a .o .out .lib .obj .exe, the output project directory name will be file.proj which omits the extension. Otherwise the output project directory name will be file.xxx.prj which keeps the original extension. Signed-off-by: Qichao Gu <[email protected]>
qichaogu
force-pushed
the
output-project-dir-name
branch
from
42efd79 to
b98bb06
Compare
mdtoguchi
previously approved these changes
Aug 5, 2021
|
You should adapt the PR description as a comment in the code. |
…directory name For "-o file.xxx" where the option value has an extension, if the extension is one of .a .o .out .lib .obj .exe, the output project directory name will be file.proj which omits the extension. Otherwise the output project directory name will be file.xxx.prj which keeps the original extension. Signed-off-by: Qichao Gu <[email protected]>
Done. |
keryell
approved these changes
Aug 6, 2021
mdtoguchi
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…directory name
For "-o file.xxx" where the option value has an extension, if the extension is one of .a .o .out .lib .obj .exe, the output project directory name will be file.proj which omits the extension. Otherwise the output project directory name will be file.xxx.prj which keeps the original extension.
Signed-off-by: Qichao Gu [email protected]