Skip to content

[SYCL] Fix for alignment requests > 64KB. #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 10, 2021
Merged

[SYCL] Fix for alignment requests > 64KB. #4263

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a461ac
[SYCL] Fix for alignment requests > 64KB.
rdeodhar Aug 5, 2021
cabdf60
[SYCL] Fix for alignment requests > 64KB.
rdeodhar Aug 5, 2021
037bc1d
Merge branch 'ij2397' of https://github.com/rdeodhar/llvm into ij2397
rdeodhar Aug 5, 2021
9238f53
Merge branch 'sycl' of https://github.com/intel/llvm into ij2397
rdeodhar Aug 6, 2021
5925d78
Remove unneeded check in USM allocator.
rdeodhar Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions sycl/plugins/level_zero/pi_level_zero.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6048,6 +6048,11 @@ pi_result piextUSMDeviceAlloc(void **ResultPtr, pi_context Context,
pi_device Device,
pi_usm_mem_properties *Properties, size_t Size,
pi_uint32 Alignment) {
// L0 supports alignment up to 64KB and silently ignores higher values.
// We flag alignment > 64KB as an invalid value.
if (Alignment > 65536)
return PI_INVALID_VALUE;

pi_platform Plt = Device->Platform;
std::unique_lock<std::mutex> ContextsLock(Plt->ContextsMutex,
std::defer_lock);
Expand Down Expand Up @@ -6106,6 +6111,11 @@ pi_result piextUSMSharedAlloc(void **ResultPtr, pi_context Context,
pi_device Device,
pi_usm_mem_properties *Properties, size_t Size,
pi_uint32 Alignment) {
// L0 supports alignment up to 64KB and silently ignores higher values.
// We flag alignment > 64KB as an invalid value.
if (Alignment > 65536)
return PI_INVALID_VALUE;

pi_platform Plt = Device->Platform;
std::unique_lock<std::mutex> ContextsLock(Plt->ContextsMutex,
std::defer_lock);
Expand Down Expand Up @@ -6162,6 +6172,11 @@ pi_result piextUSMSharedAlloc(void **ResultPtr, pi_context Context,
pi_result piextUSMHostAlloc(void **ResultPtr, pi_context Context,
pi_usm_mem_properties *Properties, size_t Size,
pi_uint32 Alignment) {
// L0 supports alignment up to 64KB and silently ignores higher values.
// We flag alignment > 64KB as an invalid value.
if (Alignment > 65536)
return PI_INVALID_VALUE;

pi_platform Plt = Context->Devices[0]->Platform;
std::unique_lock<std::mutex> ContextsLock(Plt->ContextsMutex,
std::defer_lock);
Expand Down