[SYCL] Add a workaround for a Level Zero batching issue #4268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider the following scenario on Level Zero: 1. Kernel A, which uses buffer A, is submitted to queue A. 2. Kernel B, which uses buffer B, is submitted to queue B. 3. queueA.wait(). 4. queueB.wait(). DPCPP runtime used to treat unmap/write commands for buffer A/B as host dependencies (i.e. they were waited for prior to enqueueing any command that's dependent on them). This allowed Level Zero plugin to detect that each queue is idle on steps 1/2 and submit the command list right away. This is no longer the case since we started passing these dependencies in an event waitlist and Level Zero plugin attempts to batch these commands, so the execution of kernel B starts only on step 4. This workaround restores the old behavior in this case until this is resolved.
|
/summary:run |
alexbatashev
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following scenario on Level Zero:
DPCPP runtime used to treat unmap/write commands for buffer A/B as host
dependencies (i.e. they were waited for prior to enqueueing any command
that's dependent on them). This allowed Level Zero plugin to detect that
each queue is idle on steps 1/2 and submit the command list right away.
This is no longer the case since we started passing these dependencies in
an event waitlist and Level Zero plugin attempts to batch these commands,
so the execution of kernel B starts only on step 4. This workaround
restores the old behavior in this case until this is resolved.