Skip to content

[CODEOWNERS ] Add new code owner for the Clang driver #4282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2021
Merged

[CODEOWNERS ] Add new code owner for the Clang driver #4282

merged 1 commit into from
Aug 9, 2021

Conversation

AGindinson
Copy link
Contributor

Signed-off-by: Artem Gindinson [email protected]

@AGindinson AGindinson marked this pull request as ready for review August 6, 2021 18:36
@AGindinson AGindinson requested a review from bader as a code owner August 6, 2021 18:36
@AGindinson AGindinson requested a review from mdtoguchi August 6, 2021 18:38
@AGindinson
Copy link
Contributor Author

For some reason, can't add @hchilama as a reviewer - doing this via the tag.

@bader
Copy link
Contributor

bader commented Aug 6, 2021

For some reason, can't add @hchilama as a reviewer - doing this via the tag.

Adding to codeowners file won't help either. @hchilama must have write access to be a codeowner and at least read access to be added as a reviewer.

@hchilama
Copy link
Contributor

hchilama commented Aug 6, 2021

I have requested again for the intel/llvm-write permissions. If I still won't get it, I will contact the team and see if we can figure out the issue.

@bader bader changed the title Extend CODEOWNERS for the Clang driver [CODEOWNERS ] Add new code owner for the Clang driver Aug 9, 2021
@bader bader merged commit 69e78f8 into intel:sycl Aug 9, 2021
@AGindinson AGindinson deleted the driver-codeowners branch August 13, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@mdtoguchi mdtoguchi Awaiting requested review from mdtoguchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AGindinson @bader @hchilama