[SYCL] Make vec and marray constructors constexpr #4301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is required for specialization constant implementation and was added to the SYCL 2020 specification (KhronosGroup/SYCL-Docs#133)
vladimirlaz
force-pushed
the
constexpr_vec_marray
branch
from
43b895d to
6716290
Compare
vladimirlaz
changed the title
v-klochkov
approved these changes
Aug 10, 2021
|
The only failed test is Reduction/reduction_nd_N_vars.cpp and it is disabled 3 hours ago here: intel/llvm-test-suite@14622ae |
|
/summary:run |
vladimirlaz
added a commit
to vladimirlaz/llvm
that referenced
this pull request
Aug 12, 2021
This is missing part for intel#4301. Helper functions used in constructors with variadic arguments miss constexpr.
bader
pushed a commit
that referenced
this pull request
Aug 12, 2021
This is missing part for #4301. Helper functions used in constructors with variadic arguments miss constexpr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is required for specialization constant implementation and
was added to the SYCL 2020 specification (KhronosGroup/SYCL-Docs#133)