[ESIMD] Allow copy and move constructors for simd_view #4311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allows copy and move constructors and now simd_view class adheres to the "rule of 5". We also mark APIs of simd class with [[clang::lifetimebound]] attirbute to warn users when simd_view escapes the lifetime of the underlying simd object.
DenisBakhvalov
force-pushed
the
simd_view_copy_ctor
branch
from
32aa42f to
e05d586
Compare
|
Corresponding E2E test is here: intel/llvm-test-suite#400 |
|
@rolandschulz, please review. This is basically what we agreed to do. |
rolandschulz
previously approved these changes
Aug 13, 2021
|
@kbobrovs is on vacation but we discussed this change before, he is aware of that. @rolandschulz already approved (after that I only resolved a conflict). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows copy and move constructors and now simd_view
class adheres to the "rule of 5". We also mark APIs of simd class
with [[clang::lifetimebound]] attirbute to warn users when
simd_view escapes the lifetime of the underlying simd object.