-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][Doc] Modernize GroupMask extension #4319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Opened as a draft because AsciiDoc does not want to format the +, ^ or | characters used to describe operators. @mkinsner, @rolandschulz, @jbrodman, @gmlueck -- is this something you've encountered with any other extensions? I tried using the +++ passthrough syntax but it just made things worse. |
Brings GroupMask extension in line with other extensions: - Written against SYCL 2020, with appropriate function names - Feature test macro - sycl::ext::oneapi namespace This commit replaces the old SYCL 1.2.1 extension completely in favor of a SYCL 2020 extension, because the SYCL 1.2.1 extension was never implemented. Signed-off-by: John Pennycook <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some shift in the table after row containing group_mask operator &=(group_mask rhs)
, probably related to an error syntax because of magic role of +
as you mention.
Yes! AsciiDoc is infuriating! But as luck would have it, I think I just fixed everything. Would you mind taking a quick second look? An explanation of the changes, and a note to myself for future reference:
|
GroupMask.asciidoc more consistent with other extensions.
- Maximum number of bits in a mask is now implementation-defined - vec<uint32_t, 4> replaced by marray<uint32_t, bits/sizeof(uint32_t)> to ensure that default type for insert/extract matches the implementation-defined number of bits.
Brings GroupMask extension in line with other extensions:
This commit replaces the old SYCL 1.2.1 extension completely
in favor of a SYCL 2020 extension, because the SYCL 1.2.1 extension
was never implemented.
Signed-off-by: John Pennycook [email protected]