Skip to content

[SYCL][NFC] Update status of SYCL_INTEL_local_memory extension #4323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2021

Conversation

sergey-semenov
Copy link
Contributor

No description provided.

@sergey-semenov sergey-semenov requested a review from a team as a code owner August 12, 2021 12:07
@Pennycook
Copy link
Contributor

I just took a look at the documentation and the implementation and noticed that:

  1. The extension is written against SYCL 1.2.1, not SYCL 2020
  2. The extension and implementation both use the wrong namespace (cl::sycl:: instead of sycl::ext::oneapi)

Can we fix these issues before marking the extension as "implemented"? I'm worried that once we mark things as "implemented" developers will start to use the extension, and then these issues will be harder to fix.

I can handle the rewrite of the extension, if somebody else (maybe you, Sergey) can handle the namespace changes and move the header files to the correct place.

@sergey-semenov
Copy link
Contributor Author

@Pennycook Yeah, that makes sense. I'll handle the namespace change then.

@Pennycook
Copy link
Contributor

@sergey-semenov Great, thanks! Should I push the fixed spec onto the branch associated with this PR?

@sergey-semenov
Copy link
Contributor Author

@sergey-semenov Great, thanks! Should I push the fixed spec onto the branch associated with this PR?

Let's just handle the changes separately and hold off on merging this PR until both are done.

@sergey-semenov
Copy link
Contributor Author

#4326 and #4346 have been merged. @Pennycook I think we can proceed with this.

Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks again, @sergey-semenov!

@bader bader merged commit 7c8af77 into intel:sycl Aug 19, 2021
@sergey-semenov sergey-semenov deleted the updatelocalmemstatus branch August 19, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants