Skip to content

[SYCL][Doc] Document sycl.pi.debug XPTI stream #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2021

Conversation

alexbatashev
Copy link
Contributor

Also fix minor rendering issues

@alexbatashev alexbatashev requested a review from tovinkere August 15, 2021 07:55
@alexbatashev
Copy link
Contributor Author

@tovinkere together with #4340 this will fix rendering of this page https://intel.github.io/llvm-docs/SYCLInstrumentationUsingXPTI.html

@alexbatashev alexbatashev marked this pull request as ready for review August 16, 2021 05:50
Copy link
Contributor

@tovinkere tovinkere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

| Trace Point Type | Parameter Description | Metadata |
| ---------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------- |
| Trace Point Type | Parameter Description | Metadata |
| :--------------: | :-------------------- | :------- |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like clang-format will add additional "---" to match field width, something to look out for. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think clang-format is applicable for C-based programming languages, so Markdown documents should be ignored.

bader
bader previously approved these changes Aug 18, 2021
| Trace Point Type | Parameter Description | Metadata |
| ---------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------- |
| Trace Point Type | Parameter Description | Metadata |
| :--------------: | :-------------------- | :------- |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think clang-format is applicable for C-based programming languages, so Markdown documents should be ignored.

Copy link
Contributor

@tovinkere tovinkere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbatashev alexbatashev requested a review from bader August 25, 2021 10:50
@bader bader merged commit 8eb0d87 into intel:sycl Aug 25, 2021
@alexbatashev alexbatashev deleted the xpti_pi_debug_doc branch August 25, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants