-
Notifications
You must be signed in to change notification settings - Fork 790
[SYCL][Doc] Document sycl.pi.debug XPTI stream #4341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tovinkere together with #4340 this will fix rendering of this page https://intel.github.io/llvm-docs/SYCLInstrumentationUsingXPTI.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| Trace Point Type | Parameter Description | Metadata | | ||
| ---------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------- | | ||
| Trace Point Type | Parameter Description | Metadata | | ||
| :--------------: | :-------------------- | :------- | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like clang-format will add additional "---" to match field width, something to look out for. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think clang-format
is applicable for C-based programming languages, so Markdown documents should be ignored.
| Trace Point Type | Parameter Description | Metadata | | ||
| ---------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -------- | | ||
| Trace Point Type | Parameter Description | Metadata | | ||
| :--------------: | :-------------------- | :------- | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think clang-format
is applicable for C-based programming languages, so Markdown documents should be ignored.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Also fix minor rendering issues