[SYCL][L0] Always set CommandList in _pi_context::getAvailableCommandList #4359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a command list from the cache to the map, we were not returning the newly-inserted element via
CommandList
reference.Thus, the _pi_context::getAvailableCommandList function was returning
PI_SUCCESS
, butCommandList
was left uninitialized, leading to a segfault when the command list is used later (in my case, inenqueueMemFillHelper
).Introduced in PR #4248.
I can't come up with a concise reproducer, since the bug is triggered for me in a multi-threaded application with a lot of set-up code. Example stack-trace: