Skip to content

[SYCL][NFC] Fix duplication caused by functors defined in ext::oneapi… #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2021

Conversation

v-klochkov
Copy link
Contributor

… and sycl

The functors ext::oneapi::minimum/maximum were defined identically to
sycl::minimum/maximum. Turn them into aliases of functors defined in sycl.
Remove duplicated checks for ext::oneapi functors.

Signed-off-by: Vyacheslav N Klochkov [email protected]

… and sycl

The functors ext::oneapi::minimum/maximum were defined identically to
sycl::minimum/maximum. Turn them into aliases of functors defined in sycl.
Remove duplicated checks for ext::oneapi functors.

Signed-off-by: Vyacheslav N Klochkov <[email protected]>
@v-klochkov v-klochkov marked this pull request as ready for review August 18, 2021 18:31
@v-klochkov v-klochkov requested a review from a team as a code owner August 18, 2021 18:31
@v-klochkov v-klochkov requested review from alexbatashev and dm-vodopyanov and removed request for alexbatashev August 18, 2021 18:31
@v-klochkov
Copy link
Contributor Author

v-klochkov commented Aug 18, 2021

The only failed test is: SYCL-on-device::gpu.cpp
That test fail is unrelated to this patch and the test fails for all PRs created recently

@romanovvlad
Copy link
Contributor

@v-klochkov
Isn't ext::oneapi::bit_or a public interface? If so, removing it breaks API backward compatibility.

@v-klochkov
Copy link
Contributor Author

@v-klochkov
Isn't ext::oneapi::bit_or a public interface? If so, removing it breaks API backward compatibility.

@romanovvlad This patch does not remove anything from ext::oneapi namespace. Before this patch both sycl::bit_or and ext::oneapi::bit_or were aliased to std::bit_or. That is not changed in this patch, I only removed duplicated checks:
(std::is_same<T, sycl::bit_or> || std::is_same<T, ext::oneapi::bit_or>) ==> (std::is_same<T, sycl::bit_or>).

The second change is the replacement of the duplicate struct ext::oneapi::minimum (identical to sycl::minimum) with alias to sycl::minimum. It does not remove anything and thus does not break API compatibility.

@romanovvlad romanovvlad merged commit 9a7767a into intel:sycl Aug 20, 2021
@v-klochkov v-klochkov deleted the public_vklochkov_sycl_minimum branch October 27, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants