[Driver] Remove several ESIMD-specific options #4419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously those two options were controling splitting SYCL and ESIMD code in sycl-post-link and lowering ESIMD-specific constructs after that. If there is a mix of SYCL and ESIMD kernels in a program, and we do NOT split and lower ESIMD code then the resulting binary will be broken. If we only have one type of kernels (regular SYCL or ESIMD), then those two options will have no effect. So, users should never have a situation when they need to disable those two options, i.e. use `-fno-`. Since the default should never be overwritten, we can safely remove the options.
pvchupin
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously those two options were controling splitting SYCL and ESIMD
code in sycl-post-link and lowering ESIMD-specific constructs after
that.
If there is a mix of SYCL and ESIMD kernels in a program, and we
do NOT split and lower ESIMD code then the resulting binary will be broken.
If we only have one type of kernels (regular SYCL or ESIMD), then those
two options will have no effect.
So, users should never have a situation when they need
to disable those two options, i.e. use
-fno-. Since the default shouldnever be overwritten, we can safely remove the options.