Skip to content

[SYCL] Remove sycl::byte from tests #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

maximdimakov
Copy link
Contributor

@maximdimakov maximdimakov commented Aug 30, 2021

sycl::byte is deprecated and is removed in the #4424. Tests are updated accordingly to this change
Signed-off-by: mdimakov [email protected]

@maximdimakov maximdimakov requested a review from a team as a code owner August 30, 2021 09:46
@maximdimakov maximdimakov requested a review from againull August 30, 2021 09:46
@s-kanaev
Copy link
Contributor

s-kanaev commented Sep 1, 2021

CUDA failure is a known issue and isn't related to changes in this patch.

@bader
Copy link
Contributor

bader commented Sep 2, 2021

@maximdimakov, why did you separate deletion of the tests from deletion of the API?

@bader bader changed the title [SYCL] Removed sycl::byte from tests [SYCL] Remove sycl::byte from tests Sep 2, 2021
@maximdimakov
Copy link
Contributor Author

@bader It happened accidently with sycl::byte and handler::codeplay_host_task. I will not repeat this mistake in another PRs. Do I need to merge this patch with #4424 or it would be faster to merge them separately?

@bader
Copy link
Contributor

bader commented Sep 2, 2021

I suggest closing two PRs and update another two.

@maximdimakov
Copy link
Contributor Author

Updated #4424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants