[SYCL] Remove deprecated intel::reqd_work_group_size attribute

[smanna12]

Commit 8ef7eac deprecated [[intel::reqd_work_group_size()]] attribute in favor of SYCL 2020 attribute [[sycl::reqd_work_group_size()]].

This patch removes that deprecated attribute spelling and updates several tests
with new attribute spelling of of ReqdWorkGroupSize attribute.

Signed-off-by: Soumi Manna [email protected]

[smanna12]

Fix for PreCommit test failure of Basic/reqd_work_group_size.cpp test has been tracked here: intel/llvm-test-suite#431

[premanandrao]

I think it would make sense to have at least one test that uses the removed spelling and now shows an error.

[AaronBallman]

The changes LGTM as far as they go, but do we have release notes that we should update to communicate this removal more explicitly to users?

[smanna12]

The changes LGTM as far as they go

Thanks @AaronBallman for the reviews.

Do we have release notes that we should update to communicate this removal more explicitly to users?

I am not aware of this. @romanovvlad, could you please comments on this?

[premanandrao]

LGTM. But I too would like to know if this needs to be release-noted somehow.

[AaronBallman]

LGTM

[smanna12]

Thanks @AaronBallman and @premanandrao for the reviews.

@intel/llvm-reviewers-runtime, Please review.

[romanovvlad]

The changes LGTM as far as they go

Thanks @AaronBallman for the reviews.

Do we have release notes that we should update to communicate this removal more explicitly to users?

I am not aware of this. @romanovvlad, could you please comments on this?

We have release notes - sycl/ReleaseNotes.md . They will be updated when we are close to release.

[smanna12]

New Precommit test failure is not related to my patch:

http://icl-jenkins.sc.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FWin%2FTest_Suite/detail/Test_Suite/6754/pipeline

Failed Tests (1):
SYCL :: Plugin/level_zero_dynamic_batch_test.cpp

[smanna12]

The changes LGTM as far as they go

Thanks @AaronBallman for the reviews.

Do we have release notes that we should update to communicate this removal more explicitly to users?

I am not aware of this. @romanovvlad, could you please comments on this?

We have release notes - sycl/ReleaseNotes.md . They will be updated when we are close to release.

Thanks @romanovvlad for the review and the info about the release note.

[smanna12]

Buildbot/Lit_With_Cuda is failing with error below: localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:23568:1: fatal error: error writing to /tmp/ccKj5myQ.s: No space left on device

This is unrelated to this patch.

[premanandrao]

Buildbot/Lit_With_Cuda is failing with error below: localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:23568:1: fatal error: error writing to /tmp/ccKj5myQ.s: No space left on device

This is unrelated to this patch.

@tfzhu is the contact for CI according to Alexey in another thread.

[smanna12]

Precommit test failure is not related to my patch. This PR is ready to merge.

http://icl-jenkins.sc.intel.com:8080/blue/organizations/jenkins/SYCL_CI%2Fintel%2FWin%2FTest_Suite/detail/Test_Suite/6754/pipeline

Failed Tests (1):
SYCL :: Plugin/level_zero_dynamic_batch_test.cpp