[SYCL] Add deprecation warnings for unstable keys of SYCL_DEVICE_ALLOWLIST #4455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WLIST This patch adds deprecation warnings for DeviceName and PlatformName keys of SYCL_DEVICE_ALLOWLIST and suggests using stable BackendName, DeviceType and DeviceVendorId keys instead of them
vladimirlaz
previously approved these changes
Sep 2, 2021
sycl/source/detail/allowlist.cpp
Outdated
Comment on lines
257
to
268
| if (IsDeprecatedKeyNameDeviceNameWasUsed && | ||
| IsDeprecatedKeyNamePlatformNameWasUsed) { | ||
| std::cerr << "\nWARNING: " << DeprecatedKeyNameDeviceName << " and " | ||
| << DeprecatedKeyNamePlatformName | ||
| << " in SYCL_DEVICE_ALLOWLIST are deprecated. "; | ||
| } else if (IsDeprecatedKeyNameDeviceNameWasUsed) { | ||
| std::cerr << "\nWARNING: " << DeprecatedKeyNameDeviceName | ||
| << " in SYCL_DEVICE_ALLOWLIST is deprecated. "; | ||
| } else if (IsDeprecatedKeyNamePlatformNameWasUsed) { | ||
| std::cerr << "\nWARNING: " << DeprecatedKeyNamePlatformName | ||
| << " in SYCL_DEVICE_ALLOWLIST is deprecated. "; | ||
| } |
There was a problem hiding this comment.
NIT: Isn't it better to have two independent warnings instead of having a combined one?
There was a problem hiding this comment.
I thought the less warnings user see the better
bader
reviewed
Sep 2, 2021
bader
approved these changes
Sep 3, 2021
vladimirlaz
approved these changes
Sep 7, 2021
dm-vodopyanov
deleted the
private/dvodopya/add-deprecation-warnings-for-some-allowlist-keys
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds deprecation warnings for DeviceName and PlatformName
keys of SYCL_DEVICE_ALLOWLIST and suggests using stable BackendName,
DeviceType and DeviceVendorId keys instead of them