[SYCL] Add SYCL 2020 operators sycl::logical_and and sycl::logical_or #4476
Conversation
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
| static_assert(known_identity<sycl::bit_xor<T>, T>::value == 0); | ||
| } | ||
|
|
||
| template <typename T> void checkBoolKnownIdentity() { |
There was a problem hiding this comment.
Should it also be possible to use bit_and, bit_or, bit_xor with bool? I think these operations are well defined.
There was a problem hiding this comment.
Interesting question, but I afraid it may be implementation defined. At least this doc does not mention bool type: https://en.cppreference.com/w/cpp/utility/functional/bit_and
There was a problem hiding this comment.
@Pennycook - This PR passed testing, it fixes an obvious miss. bit_and for bool is a separate and less obvious (imo). It can be supported by another PR. If you don't mind I'll merge the current PR as is.
There was a problem hiding this comment.
Sorry for the delayed response! Yes, I agree that this can be merged, and we can revisit the question of which type/operator combinations are supported later.
I think things like bit_and do work for bool, but possibly because of weird integer conversion rules in C++. It's not immediately obvious to me which combinations the SYCL specification expects to work; I'll try to get some more clarity on this point, and we can also wait to see if any users actually complain about not being able to use "weird" combinations.
bader
changed the title
Signed-off-by: Vyacheslav N Klochkov [email protected]