[SYCL] Predefine SYCL macros with vendor strings #4498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbatashev
reviewed
Sep 7, 2021
Co-authored-by: Alexander Batashev <[email protected]>
romanovvlad
reviewed
Sep 7, 2021
romanovvlad
reviewed
Sep 7, 2021
gmlueck
approved these changes
Sep 7, 2021
alexbatashev
approved these changes
Sep 7, 2021
|
@dsawfer, can you please add a description for this PR? |
|
@dsawfer @alexbatashev Should tests need to be added? |
There's a test in the tests folder. What other kind of testing are you thinking of? |
Sorry, missed that somehow. |
Thanks! |
DoyleLi
pushed a commit
to DoyleLi/intel_llvm
that referenced
this pull request
Sep 13, 2021
The SYCL 2020 specification requires at least one macro of the form SYCL_IMPLEMENTATION_"vendorstring" to be predefined, which allows applications to check if they compile with this provider's implementation. Our vendorstrings are SYCL_IMPLEMENTATION_ONEAPI and SYCL_IMPLEMENTATION_INTEL. The SYCL_FEATURE_SET_FULL macro is mandated by section 5.6. "Preprocessor directives and macros" of the SYCL 2020 specification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SYCL 2020 specification requires at least one macro of the form SYCL_IMPLEMENTATION_"vendorstring" to be predefined, which allows applications to check if they compile with this provider's implementation.
Our vendorstrings are SYCL_IMPLEMENTATION_ONEAPI and SYCL_IMPLEMENTATION_INTEL. The SYCL_FEATURE_SET_FULL macro is mandated by section 5.6. "Preprocessor directives and macros" of the SYCL 2020 specification.