[SYCL] Add half constexpr default constructor #4518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elect Signed-off-by: mdimakov <[email protected]>
|
@maximdimakov, please add tests. |
|
@dm-vodopyanov I added clarifying comments and tests |
|
@AlexeySachkov @dm-vodopyanov could you, please, review? |
AlexeySachkov
approved these changes
Sep 13, 2021
dm-vodopyanov
approved these changes
Sep 13, 2021
romanovvlad
pushed a commit
that referenced
this pull request
Oct 4, 2021
Return trivial default constructor to half type. Without default constructor it is impossible to create union with half type. Changed implementation of marray and half_vec constructors for optimizing them to use half with trivial default constructor. Update files accordingly to returned half trivial default constructor. This patch corrects #4518 Signed-off-by: mdimakov [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add default constexpr constructor for half and host half classes, and also for half_vec struct.
Due to bitselect built-in uses union with half specialization, but object of a class without trivial constructor cannot be a member of union, the builtins_helper struct was added. This struct allow to use host half class instead of main half class in the builtin.
Signed-off-by: mdimakov [email protected]