Skip to content

[SYCL][XPTI] Enable XPTI tests #4545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 28, 2021
Merged

Conversation

alexbatashev
Copy link
Contributor

Brief overview of changes:

  • Fix XPTI libraries deployment locations in CMake
  • Fix incorrect definitions and options in CMake
  • Enable -Werror for XPTI by default
  • Add LLVM-style target check-xptifw
  • Run check-xptifw by default in GitHub Actions post-commit job
  • Fix whatever warnings the compiler complained about.

@alexbatashev
Copy link
Contributor Author

E2E tests are added with intel/llvm-test-suite#458

@bader
Copy link
Contributor

bader commented Sep 13, 2021

  • Enable -Werror for XPTI by default

It would be great to enforce this only in CI, but not by default to avoid build issues for developers using "non-standard" development environment.

* upstream/sycl: (36 commits)
  [SYCL] Add SYCL2020 target::device enumeration value (intel#4587)
  [SYCL][Doc] Update ITT instrumentation docs (intel#4503)
  [SYCL][L0] Make all L0 events have device-visibility (intel#4534)
  [SYCL] Updated Level-Zero backend spec according to SYCL 2020 standard (intel#4560)
  [SYCL] Add error_code support for SYCL 1.2.1 exception classes (intel#4574)
  [SYCL][CI] Provide --ci-defaults option for config script (intel#4583)
  [CI] Switch GitHub Actions to Ubuntu 20.04 (intel#4582)
  [SYCL][CUDA] Fix context clearing in PiCuda tests (intel#4483)
  [SYCL] Hide SYCL service kernels (intel#4519)
  [SYCL][L0] Fix mismatched ZE call count (intel#4559)
  [SYCL] Remove function pointers extension (intel#4459)
  [GitHub Actions] Uplift clang version in post-commit validation (intel#4581)
  [SYCL] Ignore usm prefetch dummy flag (intel#4568)
  [SYCL][Group algorithms] Add group sorting algorithms implementation (intel#4439)
  [SYCL] Resolve name clash with a user defined symbol (intel#4570)
  [clang-offload-wrapper] Do not create .tgtimg section with -emit-reg-funcs=0 (intel#4577)
  [SYCL][FPGA] Remove deprecated attribute functionality (intel#4532)
  [SYCL] Remove _class aliases (intel#4465)
  [SYCL][CUDA][HIP] Report every device in its own platform (intel#4571)
  [SYCL][L0] make_device shouldn't need platform as an input (intel#4561)
  ...
smaslov-intel
smaslov-intel previously approved these changes Sep 20, 2021
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbatashev
Copy link
Contributor Author

The test failure is not caused by this patch and more seems like some infra issue.

@alexbatashev alexbatashev requested a review from bader September 21, 2021 10:04
bader
bader previously approved these changes Sep 21, 2021
andykaylor
andykaylor previously approved these changes Sep 23, 2021
Copy link
Contributor

@andykaylor andykaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks for the updates!

@vladimirlaz vladimirlaz merged commit 183caf3 into intel:sycl Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants